[css-ui] Fix accidental syntax regression #13018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[foo,]* and foo#? are not equivalent, as the former has a trailing comma. See w3c#13001
keithamus
added a commit
to csskit/csskit
that referenced
this pull request
Oct 27, 2025
w3c/csswg-drafts#13018 changed the syntax of Cursor from using `#?` to `,]*`. This subtle change means trailing commas are always required. We didn't support this for a couple of reasons: - Punct wasn't being rendered correctly due to quoting of the char, so `T![,]` was rendering as `T![',']` which isn't a known macro. css_parse could have included quoted variants of all characters, or we could have updated csskit_proc_macro to unquote the chars, which is what this change does. - `T![,]` wasn't Visitable, meaning the `Vec<'a, (X, T![,])>` wasn't Visitable either. Both `Vec` & `(A, B)` _are_ visitable, so it's only `T![,]` that needs to be to make the whole thing work. This change makes `T![,]` Visitable.
keithamus
added a commit
to csskit/csskit
that referenced
this pull request
Oct 27, 2025
w3c/csswg-drafts#13018 changed the syntax of Cursor from using `#?` to `,]*`. This subtle change means trailing commas are always required. We didn't support this for a couple of reasons: - Punct wasn't being rendered correctly due to quoting of the char, so `T![,]` was rendering as `T![',']` which isn't a known macro. css_parse could have included quoted variants of all characters, or we could have updated csskit_proc_macro to unquote the chars, which is what this change does. - `T![,]` wasn't Visitable, meaning the `Vec<'a, (X, T![,])>` wasn't Visitable either. Both `Vec` & `(A, B)` _are_ visitable, so it's only `T![,]` that needs to be to make the whole thing work. This change makes `T![,]` Visitable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[foo,]*andfoo#?are not equivalent, as the former has a trailing comma.See #13001